minor #29745 SCA: minor code tweaks (kalessil)

This PR was squashed before being merged into the 4.1 branch (closes #29745). Discussion ---------- SCA: minor code tweaks | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Eliminated a few excessive calls, tweaked query parameters sorting Commits ------- 8887f76 SCA: minor code tweaks
symfony · Jan 13, 2019 · 1874369 · 1874369
2 parents c325155 + 8887f76
commit 1874369
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -563,9 +563,7 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
             $metadataStoreDefinition->replaceArgument(2, $transitionsMetadataDefinition);
 
             // Create places
-            $places = array_map(function (array $place) {
-                return $place['name'];
-            }, $workflow['places']);
+            $places = array_column($workflow['places'], 'name');
 
             // Create a Definition
             $definitionDefinition = new Definition(Workflow\Definition::class);

diff --git a/src/Symfony/Component/Messenger/DataCollector/MessengerDataCollector.php b/src/Symfony/Component/Messenger/DataCollector/MessengerDataCollector.php
@@ -62,9 +62,7 @@ public function lateCollect()
         });
 
         // Keep the messages clones only
-        $this->data['messages'] = array_map(function (array $item): Data {
-            return $item[0];
-        }, $messages);
+        $this->data['messages'] = array_column($messages, 0);
     }
 
     /**

diff --git a/src/Symfony/Component/Serializer/Mapping/Loader/XmlFileLoader.php b/src/Symfony/Component/Serializer/Mapping/Loader/XmlFileLoader.php
@@ -71,7 +71,8 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata)
             if (isset($xml->{'discriminator-map'})) {
                 $mapping = array();
                 foreach ($xml->{'discriminator-map'}->mapping as $element) {
-                    $mapping[(string) $element->attributes()->type] = (string) $element->attributes()->class;
+                    $elementAttributes = $element->attributes();
+                    $mapping[(string) $elementAttributes->type] = (string) $elementAttributes->class;
                 }
 
                 $classMetadata->setClassDiscriminatorMapping(new ClassDiscriminatorMapping(