Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #36162 [Profiler] Fix profiler nullable string type (mRoca)
This PR was merged into the 5.0 branch. Discussion ---------- [Profiler] Fix profiler nullable string type | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | - This PR fixes nullable string types in setter for the Profile class. The detected issue comes from [the Profiler class](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Profiler/Profiler.php#L149) : ```php $profile->setIp($request->getClientIp()); // string or null ``` The corresponding return types for the Profile getters are allready good: ```php /** * Returns the IP. * * @return string|null The IP */ public function getIp() { return $this->ip; } ``` Commits ------- b5d4061 Fix profiler nullable string type
- Loading branch information