Skip to content

Commit

Permalink
minor #33131 [Form] Add bool type to ChoiceListFactoryInterface::crea…
Browse files Browse the repository at this point in the history
…teView $label argument (vudaltsov)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Add bool type to ChoiceListFactoryInterface::createView $label argument

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Replaces #33074
Ping @nicolas-grekas , @Tobion , @yceruto .

Commits
-------

8f5d1ca Add false type to ChoiceListFactoryInterface::createView $label argument
  • Loading branch information
nicolas-grekas committed Aug 13, 2019
2 parents fcdc61a + 8f5d1ca commit 502be37
Showing 1 changed file with 5 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,11 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, $value = nul
* attributes that should be added to the respective choice.
*
* @param array|callable|null $preferredChoices The preferred choices
* @param callable|null $label The callable generating the
* choice labels
* @param callable|null $index The callable generating the
* view indices
* @param callable|null $groupBy The callable generating the
* group names
* @param array|callable|null $attr The callable generating the
* HTML attributes
* @param callable|false|null $label The callable generating the choice labels;
* pass false to discard the label
* @param callable|null $index The callable generating the view indices
* @param callable|null $groupBy The callable generating the group names
* @param array|callable|null $attr The callable generating the HTML attributes
*
* @return ChoiceListView The choice list view
*/
Expand Down

0 comments on commit 502be37

Please sign in to comment.