-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #16912 [Translation][Writer] avoid calling setBackup if the dumpe…
…r is not FileDumper (aitboudad) This PR was merged into the 2.7 branch. Discussion ---------- [Translation][Writer] avoid calling setBackup if the dumper is not FileDumper | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | n/a Commits ------- 369b2d4 [Translation][Writer] avoid calling setBackup if the dumper is not an instance of FileDumper.
- Loading branch information
Showing
2 changed files
with
50 additions
and
1 deletion.
There are no files selected for viewing
47 changes: 47 additions & 0 deletions
47
src/Symfony/Component/Translation/Tests/Writer/TranslationWriterTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\Translation\Tests\Writer; | ||
|
||
use Symfony\Component\Translation\MessageCatalogue; | ||
use Symfony\Component\Translation\Writer\TranslationWriter; | ||
|
||
class TranslationWriterTest extends \PHPUnit_Framework_TestCase | ||
{ | ||
public function testWriteTranslations() | ||
{ | ||
$dumper = $this->getMock('Symfony\Component\Translation\Dumper\DumperInterface'); | ||
$dumper | ||
->expects($this->once()) | ||
->method('dump'); | ||
|
||
$writer = new TranslationWriter(); | ||
$writer->addDumper('test', $dumper); | ||
$writer->writeTranslations(new MessageCatalogue(array()), 'test'); | ||
} | ||
|
||
public function testDisableBackup() | ||
{ | ||
$dumper = $this->getMock('Symfony\Component\Translation\Dumper\DumperInterface'); | ||
$dumper | ||
->expects($this->never()) | ||
->method('setBackup'); | ||
$phpDumper = $this->getMock('Symfony\Component\Translation\Dumper\PhpFileDumper'); | ||
$phpDumper | ||
->expects($this->once()) | ||
->method('setBackup'); | ||
|
||
$writer = new TranslationWriter(); | ||
$writer->addDumper('test', $dumper); | ||
$writer->addDumper('php', $phpDumper); | ||
$writer->disableBackup(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters