bug #43569 [HttpClient] fix collecting debug info on destruction of C…

…urlResponse (nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] fix collecting debug info on destruction of CurlResponse

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #43348
| License       | MIT
| Doc PR        | -

Commits
-------

f0b52c8 [HttpClient] fix collecting debug info on destruction of CurlResponse

src/Symfony/Component/HttpClient/Response/CurlResponse.php

@@ -225,13 +225,15 @@ public function getContent(bool $throw = true): string
 
     public function __destruct()
     {
-        curl_setopt($this->handle, \CURLOPT_VERBOSE, false);
+        try {
+            if (null === $this->timeout) {
+                return; // Unused pushed response
+            }
 
-        if (null === $this->timeout) {
-            return; // Unused pushed response
+            $this->doDestruct();
+        } finally {
+            curl_setopt($this->handle, \CURLOPT_VERBOSE, false);
         }
-
-        $this->doDestruct();
     }
 
     /**

src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php

@@ -167,4 +167,16 @@ public function testHandleIsRemovedOnException()
             $this->assertCount(0, $clientState->openHandles);
         }
     }
+
+    public function testDebugInfoOnDestruct()
+    {
+        $client = $this->getHttpClient(__FUNCTION__);
+
+        $traceInfo = [];
+        $client->request('GET', 'http://localhost:8057', ['on_progress' => function (int $dlNow, int $dlSize, array $info) use (&$traceInfo) {
+            $traceInfo = $info;
+        }]);
+
+        $this->assertNotEmpty($traceInfo['debug']);
+    }
 }