Skip to content

Commit

Permalink
bug #48288 [Security] Make onAuthenticationSuccess Response optional …
Browse files Browse the repository at this point in the history
…(db306)

This PR was merged into the 6.2 branch.

Discussion
----------

[Security] Make onAuthenticationSuccess Response optional

| Q             | A
| ------------- | ---
| Branch?       | 6.0, 6.1, and 6.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT

Most authenticators currently use onAuthenticationSuccess with an optional Response. That's mainly due to usecases whereby we want to redirect specific users etc.

Commits
-------

1e95ac7 Make onAuthenticationSuccess Response optional
  • Loading branch information
fabpot committed Apr 21, 2023
2 parents b3bfdf9 + 1e95ac7 commit e1bcdd5
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ interface AuthenticationSuccessHandlerInterface
/**
* Usually called by AuthenticatorInterface::onAuthenticationSuccess() implementations.
*/
public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response;
public function onAuthenticationSuccess(Request $request, TokenInterface $token): ?Response;
}

0 comments on commit e1bcdd5

Please sign in to comment.