FormTypeValidatorExtension uses wrong entity

[tobias-93]

The variable $validator of Symfony\Component\Form\Extension\Validator\Type\FormTypeValidatorExtension uses Symfony\Component\Validator\ValidatorInterface, which is moved to Symfony\Component\Validator\Validator\ValidatorInterface since Symfony 2.5 . Please change this in this entity.

Regards, Tobias Feijten

[stof]

It is not moved. There is a new interface in Symfony 2.5, while the old one is still there.

However, it is true that the FormTypeValidatorExtension should be updated to accept both implementations

[cjunge-work]

I've just updated to Symfony 2.5, and using the new validator with forms is throwing an error related to the expected interface being wrong. I have set my config to api: 2.5.

As stated above, the Validator is being created using the new classes (implementing Symfony\Component\Validator\Validator\ValidatorInterface) while the Form extension is expecting the old interface. This makes the out-of-the-box experience unusable.

By changing the config to api: auto it works correctly.

[stof]

@cjunge-work given that most bundles still support Symfony 2.3 as it is the LTS, switching to api: 2.5 is not the best idea yet. It is much better to run in BC mode (i.e. supporting both the 2.4 and 2.5 apis), which is done by api: auto on PHP 5.3.9+

[tobias-93]

@stof Same goes for Symfony\Component\Form\Extension\Validator\EventListener\ValidationListener, by the way

[cordoval]

this is messed up then:

 Matthias\SymfonyServiceDefinitionValidator\Exception\InvalidServiceDefinitionsException]
Service definition validation errors (2):

form.type_guesser.validator: Argument for type-hint "Symfony\Component\Validator\MetadataFactor
yInterface" points to a service of class "Symfony\Component\Validator\ValidatorInterface"
validator: Class "Symfony\Component\Validator\ValidatorBuilderInterface" does not exist

related matthiasnoback/symfony-service-definition-validator#12

[matthiasnoback]

Indeed, the service definitions are invalid here (see the issue that @cordoval pointed to). The form.type_guesser.validator needs an instance of MetadataFactoryInterface for which the validator service is used, but that service is defined as being of class ValidatorInterface (which itself does not extend from MetadataFactoryInterface, though the actual Validator class does).

I think this should be fixed for consistency sake. I will make a pull request for this later.

[tobias-93]

@stof Any update on this work yet? @cordoval I don't think your pull request will fix this ticket, but it will fix the problem you have.

[marfillaster]

Also to add, using auto api causes errors of different fields to pile up onto a single field, usually the last. 2.4 api doesn't have this issue.

[sebastianblum]

in my opinion, from the validator is only the validate method used.
and this method is available in the validator until 2.4

public function validate($value, $groups = null, $traverse = false, $deep = false);
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/ValidatorInterface.php#L46

and in the new validator since 2.5

public function validate($value, $constraints = null, $groups = null);
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Validator/ValidatorInterface.php#L44

So I think we can solve this issue with a code like this:

<?php
public function __construct($validator)
{
    if ($validator instanceof \Symfony\Component\Validator\ValidatorInterface  // 2.4
        || $validator instanceof \Symfony\Component\Validator\Validator\ValidatorInterface // 2.5
    ) {
        $this->validator = $validator;
    } else {
        throw new \InvalidArgumentException('Validator should be instanceof ValidatorInterface');
     }
    $this->violationMapper = new ViolationMapper();
}

The instance of checks is not a nice solution, but I works.

@webmozart do you have a better solution?

I can create a pull request and with tests, if the core members think this could be a solution for the problem.
greetings from munich, sebastian

[sebastianblum]

We have the same issue here in the EventListener

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Validator/EventListener/ValidationListener.php#L38

[stof]

@sebastianblum doing instanceof checks in the constructor is the right solution IMO. Can you send a PR fixing it ?

[sebastianblum]

Yes, I will do it for the FormTypeValidatorExtension and theValidationListener

[tobias-93]

@sebastianblum I think #11049 can be solved this way as well. Could you do this for ConstraintValidator and ConstraintValidatorInterface as well?

[sebastianblum]

Hello!

I created a pull request #11350

can you please check my commit and discuss it.

If it is ok, I will try to fix #11049

[tobias-93]

@sebastianblum Thanks!