Decouple Validator from Translation component

[dawehner]

Hi.

Some people are wondering why the validator component needs to depend on the translation component and instead could be decoupled?

[dawehner]

See https://www.drupal.org/node/2546618

[stof]

Well, violation constraints are returned translated already (since 2.2). This is why there is a dependency. Previously, there was 2 different ways to access the violation message depending on whether you wanted to use the translation system or no (and 2 different way to build violations depending on whether you wanted to make them compatible with the usage of translations or no)

[fabpot]

see #6189 and #6137 as well.

[linaori]

Maybe the validator component could have it's own interfaces for it and have a recommended implementation by using the Symfony translations via adapters? Especially when used as component I think this dependency should not be a require, but suggest.

[dawehner]

Note: Drupal is using now a pretty interesting trick.

We provide the TranslationInterface in its own folder as part of the Drupal project (together with the LICENSE file) and use a "replace" entry in composer.json to trick composer. Actually something like that could be done as hack for the validator as well, but I agree separating the interface in its own package would be better

[TomasVotruba]

@dawehner 👍

[dawehner]

And we realized that this was a horrible idea, because noone else is actually able to depend on a package which actually depend on the translation component and we reverted that.

[HadesArchitect]

@dawehner Very nice idea. Also thought about it a lot.

[nicolas-grekas]

Should be finally solved by #28210 (ping @alexpott also.)