[BrowserKit] Corrected HTTP_HOST logic #16265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!$this->history->isEmpty()) { | ||
| $server['HTTP_REFERER'] = $this->history->current()->getUri(); | ||
| } | ||
|
|
||
| $server['HTTP_HOST'] = $this->extractHost($uri); | ||
| if (empty($server['HTTP_HOST'])) { | ||
| $server['HTTP_HOST'] = $this->extractHost($uri); |
There was a problem hiding this comment.
indentation is wrong, should be increments of 4 spaces.
|
Looks like a bug to me and as such should be merged in 2.3 (@Naktibalda no need to re-create another PR as I can do the switch when merging). ping @dunglas |
|
👍 |
|
👍, but maybe should we emulate |
|
@dunglas but that's a different topic. |
|
Thank you @Naktibalda. |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2016
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #16265). Discussion ---------- [BrowserKit] Corrected HTTP_HOST logic HTTP_HOST is just a header - it does not override URI, uri does not override HTTP_HOST header. If HTTP_HOST is not set then and only then hostname is extracted from uri. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15398 | License | MIT | Doc PR | Commits ------- b5f524d [BrowserKit] Corrected HTTP_HOST logic #15398
Merged
This was referenced Feb 28, 2016
Merged
Merged
Merged
|
This change broke our test cases for testing domain specific behavior that we were testing with In case anyone runs into the same issue, we now use this code for the test: |
|
I ran into the same issue as @advancingu. |
|
Please open a new issue if you think there's been a regression introduced. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [BrowserKit] fixed BC Break for HTTP_HOST header | Q | A | ------------- | --- | Branch? | 2.7, 2.8, 3.x, 4.x | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #22933 | License | MIT | Doc PR | n/a The situation well described in the original issue. I will add only: - #10549 - makes server parameters to take precedence over URI. - #16265 - partially revererts #10549. Makes server parameters do not affect URI. But this is only true for `Client::request()`. It is still possible to set host for URI by `Client::setServerParameters()` when URI is realative (see examples below). I propose a compromise solution: add to HTTP_HOST header power to override URI when it is relative. Proposed solution: - if the request URI is relative, then use the HTTP_HOST header passed to Client::request() to generate an absolute URI - if the request URI is absolute, then ignore the HTTP_HOST header (as it now works) - do the same with HTTPS server parameter Profit: - fix BC Break - the documentation will be correct - http://symfony.com/doc/2.8/routing/hostname_pattern.html#testing-your-controllers - https://symfony.com/doc/2.8/testing.html#testing-configuration Before: ``` $client->setServerParameters(['HTTP_HOST' => 'example.com']); $client->request('GET', '/'); $this->assertEquals('http://example.com/', $client->getRequest()->getUri()); $client->request('GET', '/', [], [], ['HTTP_HOST' => 'example.com']); $this->assertEquals('http://localhost/', $client->getRequest()->getUri()); ``` Fixed (see last line): ``` $client->setServerParameters(['HTTP_HOST' => 'example.com']); $client->request('GET', '/'); $this->assertEquals('http://example.com/', $client->getRequest()->getUri()); $client->request('GET', '/', [], [], ['HTTP_HOST' => 'example.com']); $this->assertEquals('http://example.com/', $client->getRequest()->getUri()); ``` Commits ------- 8c4a594 [BrowserKit] fixed BC Break for HTTP_HOST header; implemented same behaviour for HTTPS server parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP_HOST is just a header - it does not override URI,
uri does not override HTTP_HOST header.
If HTTP_HOST is not set then and only then hostname is extracted from uri.