Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Security tweaks to SecurityExtension #1111

Closed
wants to merge 4 commits into from
Closed

[Security] Security tweaks to SecurityExtension #1111

wants to merge 4 commits into from

Commits on May 26, 2011

  1. [Security] Adding a little PHPDoc

    @weaverryan
    weaverryan committed May 26, 2011
    Configuration menu
    Copy the full SHA
    16aab5e View commit details
    Browse the repository at this point in the history

  2. [Security][DI] Removing unused variable and closing an unused XML tag

    @weaverryan
    weaverryan committed May 26, 2011
    Configuration menu
    Copy the full SHA
    9d5aadb View commit details
    Browse the repository at this point in the history

  3. [SecurityBundle] Heavy, but mostly meaningless cleanup of the Securit… 

    …yExtension class

This is mostly a result of trying to make the class more readable while studying it. Soem variable names were made more explicit, comments were added in many places, and a few other changes were made:

 * The security.context.listener.* services were renamed - the final portion was a counter before, it's now the firewall name, which makes more sense and is more consistent with the behavior of the rest of the class

 * User provider validation was added: if you specify a provider under your firewall or authentication listener that's not in the "providers" array, a LogicException is thrown
    @weaverryan
    weaverryan committed May 26, 2011
    Configuration menu
    Copy the full SHA
    fef4e45 View commit details
    Browse the repository at this point in the history

  4. [Security] Fixing CS per @stof

    @weaverryan
    weaverryan committed May 26, 2011
    Configuration menu
    Copy the full SHA
    8b416da View commit details
    Browse the repository at this point in the history