[Serializer] Normalizers can serialize collections and scalars #13500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be able to cover this with tests? |
dunglas
added a commit
to dunglas/symfony
that referenced
this pull request
Jan 23, 2015
|
@jakzal tests added. |
dunglas
force-pushed
the
normalize_collection
branch
from
5a39d19
to
9bbe56f
Compare
dunglas
added a commit
to dunglas/symfony
that referenced
this pull request
Jan 23, 2015
| $class = get_class($data); | ||
| if (isset($this->normalizerCache[$class][$format])) { | ||
| return $this->normalizerCache[$class][$format]; | ||
| if ($isObject = is_object($data)) { |
There was a problem hiding this comment.
if you can pass something else than an object to this method, you need to update the phpdoc
|
For Traversable objects, it is already possible to customize it |
dunglas
force-pushed
the
normalize_collection
branch
from
9bbe56f
to
2381c7d
Compare
|
@stof right. Fixed the PR description and the PHPDoc. |
|
The Travis failure seems unrelated with this PR. |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2015
… scalars (dunglas) This PR was squashed before being merged into the 2.7 branch (closes #13500). Discussion ---------- [Serializer] Normalizers can serialize collections and scalars | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT | Doc PR | n/a Currently, the logic for serializing `array` and scalars is hardcoded in the serializer. This is not possible to have a custom serializer normalizing collections. This a big limitation, for instance it's not possible to create an normalizer creating [Hydra collections](http://www.hydra-cg.com/spec/latest/core/#h-collections) for a PHP array. This PR fix that. Commits ------- 1cf8eb2 [Serializer] Normalizers can serialize collections and scalars
fabpot
added a commit
that referenced
this pull request
May 5, 2015
…dunglas) This PR was merged into the 2.7 branch. Discussion ---------- [Serializer] Ignore \Traversable in default normalizers. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14495 | License | MIT | Doc PR | n/a Before the merge of #13500, default normalizers where never called for `\Traversable` objects. This PR restore the previous behavior in a cleaner way. This is also convenient when dealing with Doctrine's ArrayCollection and serialization groups (see #14495). ping @symfony/deciders Commits ------- c9bff46 [Serializer] Ignore \Traversable in default normalizers. Close #14495.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logic for serializing
arrayand scalars is hardcoded in the serializer. This is not possible to have a custom serializer normalizing collections. This a big limitation, for instance it's not possible to create an normalizer creating Hydra collections for a PHP array.This PR fix that.