[FrameworkBundle] Applied new styles to the config:debug & config:dump-reference commands #14591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogizanagi Can you please show before and after screenshots? |
|
Sure. Here it is. (Only the table layout listing bundles and the deprecation note is changed)
|
| if (class_exists('Symfony\Component\Console\Helper\Table')) { | ||
| $table->render(); | ||
| $message = 'Available registered bundles with their extension alias if available:'; | ||
| if ($output instanceof OutputStyle) { |
There was a problem hiding this comment.
This method is typehinted OutputInterface. As it might eventually be used by other bundles, not using SymfonyStyle nor custom StyleInterface implementations, we need to do this check in order to choose the way we'll use in order to render the table.
Unless we judge other bundles should not extend this class, so we could typehint this method with the StyleInterface.
BTW, I don't remember why I used OutputStyle instead of StyleInterface :/
…p-reference commands
|
👍 |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
May 15, 2015
… & config:dump-reference commands (ogizanagi) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Applied new styles to the config:debug & config:dump-reference commands | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | Partially #14138 | License | MIT | Doc PR | - Min dependency on `symfony/console` is changed to `~2.7` in the FrameworkBundle, as it will be a requirement in order to update each command provided in this bundle. Commits ------- e56a619 [FrameworkBundle] Applied new styles to the config:debug & config:dump-reference commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Min dependency on
symfony/consoleis changed to~2.7in the FrameworkBundle, as it will be a requirement in order to update each command provided in this bundle.