[DomCrawler] Add support for formaction and formmethod attributes #20467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
Nov 9, 2016
| public function testGetUriWithActionOverride() | ||
| { | ||
| $form = $this->createForm('<form action="/foo"><button type="submit" formaction="/bar" /></form>', null, 'http://localhost/foo/'); | ||
| $this->assertEquals('http://localhost/bar', $form->getUri(), '->getUri() returns absolute URIs'); |
There was a problem hiding this comment.
Here you are testing getUri() but in your PR you have changed getRawUri(), right?
There was a problem hiding this comment.
Maybe because getRawUri is a protected method (can't be tested directly), which is called by public getUri method.
There was a problem hiding this comment.
indeed. getUri (defined in the parent class) calls getRawUri and then resolve the URI to account for non-absolute ones (like in this test)
| { | ||
| $form = $this->createForm('<form action="/foo"><button type="submit" formaction="/bar" /></form>', null, 'http://localhost/foo/'); | ||
| $this->assertEquals('http://localhost/bar', $form->getUri(), '->getUri() returns absolute URIs'); | ||
|
|
There was a problem hiding this comment.
Extra blank line should be removed.
|
👍 Status: reviewed |
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Dec 2, 2016
… attributes (stof) This PR was merged into the 3.3-dev branch. Discussion ---------- [DomCrawler] Add support for formaction and formmethod attributes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This adds supports for the ``formaction`` and ``formmethod`` of submit elements, which override the values defined on the ``<form>`` element. This works only when you call ``$crawler->form()`` on a Crawler containing a button, not when it contains the ``<form>`` itself of course (as the button override is applied only when using this button to submit, not when using another way). Other button-level overrides are not implemented: - ``formtarget`` is useless as we don't implement ``target`` either (the Crawler does not deal with frame-based pages anyway) - ``formnovalidate`` is ignored, as we don't automatically disable the form validation on ``novalidate`` either, but we require an explicit disabling instead (this might be subject to a separate PR though, as it could make sense) - ``formenctype`` is ignored as we also ignore ``enctype`` (we always submit file fields, even when missing the proper enctype) Commits ------- 717cf8a [DomCrawler] Add support for formaction and formmethod attributes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds supports for the
formactionandformmethodof submit elements, which override the values defined on the<form>element.This works only when you call
$crawler->form()on a Crawler containing a button, not when it contains the<form>itself of course (as the button override is applied only when using this button to submit, not when using another way).Other button-level overrides are not implemented:
formtargetis useless as we don't implementtargeteither (the Crawler does not deal with frame-based pages anyway)formnovalidateis ignored, as we don't automatically disable the form validation onnovalidateeither, but we require an explicit disabling instead (this might be subject to a separate PR though, as it could make sense)formenctypeis ignored as we also ignoreenctype(we always submit file fields, even when missing the proper enctype)