[Form] Check for Intl availibility #28610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Sep 26, 2018
| @@ -41,6 +42,10 @@ public function configureOptions(OptionsResolver $resolver) | |||
| { | |||
| $resolver->setDefaults(array( | |||
| 'choice_loader' => function (Options $options) { | |||
| if (!class_exists(Intl::class)) { | |||
| throw new LogicException('The "symfony/intl" component is required to use the Country type.'); | |||
| } | |||
There was a problem hiding this comment.
Could we move this to IntlCallbackChoiceLoader instead?
There was a problem hiding this comment.
the message would be less obvious.. currently it hints Country type etc.
OskarStark
reviewed
Sep 27, 2018
| @@ -41,6 +42,10 @@ public function configureOptions(OptionsResolver $resolver) | |||
| { | |||
| $resolver->setDefaults(array( | |||
| 'choice_loader' => function (Options $options) { | |||
| if (!class_exists(Intl::class)) { | |||
| throw new LogicException('The "symfony/intl" component is required to use the Country type.'); | |||
There was a problem hiding this comment.
I would prefer LanguageType:class, to get the FQCN here, same for the other exceptions
chalasr
approved these changes
Sep 28, 2018
xabbuh
approved these changes
Sep 28, 2018
There was a problem hiding this comment.
but @OskarStark's suggestion to enhance the message sounds good to me
fabpot
approved these changes
Sep 29, 2018
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Sep 29, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Form] Check for Intl availibility | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Same as #28513 for the form component Commits ------- 73c688c [Form] Check for Intl availibility
nicolas-grekas
added a commit
that referenced
this pull request
Jan 3, 2019
…(ro0NL)" (chalasr) This PR was merged into the 4.2 branch. Discussion ---------- Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)" | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Intl is an hard dependency for Form, these checks cannot be reached. Commits ------- 3ac98a6 Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)"
chalasr
pushed a commit
that referenced
this pull request
Jan 4, 2019
* 4.2: Ensure final input of CommandTester works with default Do not risk waiting 100 seconds [Intl] handle null date and time types Revert "minor #28610 [Form] Check for Intl availibility (ro0NL)" Do not ignore the choice groups for caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #28513 for the form component