New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Fixed empty data for compound date types #29182

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
4 participants
@HeahDude
Member

HeahDude commented Nov 11, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #4715
License MIT
Doc PR ~

@HeahDude HeahDude force-pushed the HeahDude:fix-date-empty-data-compound branch from 90a0ab0 to d53e21a Nov 11, 2018

@HeahDude HeahDude force-pushed the HeahDude:fix-date-empty-data-compound branch from d53e21a to 9bab1e8 Nov 11, 2018

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Nov 12, 2018

@HeahDude

This comment has been minimized.

Member

HeahDude commented Nov 12, 2018

To give more context, https://github.com/symfony/symfony/pull/29179/files#diff-1c1084613d7579bc9e39092ac95364f9R1020 is the test revealing the inconsistency prior to fix compound cases in this PR.

@xabbuh

xabbuh approved these changes Nov 13, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Nov 15, 2018

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit 9bab1e8 into symfony:2.8 Nov 15, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 15, 2018

bug #29182 [Form] Fixed empty data for compound date types (HeahDude)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Fixed empty data for compound date types

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #4715
| License       | MIT
| Doc PR        | ~

Commits
-------

9bab1e8 [Form] Fixed empty data for compound date types

@HeahDude HeahDude deleted the HeahDude:fix-date-empty-data-compound branch Nov 15, 2018

@fabpot fabpot referenced this pull request Nov 16, 2018

Merged

Release v4.2.0-BETA2 #29237

nicolas-grekas added a commit that referenced this pull request Nov 20, 2018

bug #29249 [Form] Fixed empty data for compound date interval (HeahDude)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Fixed empty data for compound date interval

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #4715 (continuation)
| License       | MIT
| Doc PR        | ~

Following #29182, since this type has been introduced in Symfony 3 but with the same limitation explained in #4715.
So for consistency this needs to be fixed here as well.

Commits
-------

38a2abc [Form] Fixed empty data for compound date interval

This was referenced Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment