Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() #29197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm proposing to revert this method because it fits nowhere: we cannot use it in the console recipe because the method is in fwb. Logic fits only inlined in bin/console as in symfony/recipes#491 |
ogizanagi
approved these changes
Nov 13, 2018
We are instantiating the FWB |
|
The issue is that even if the code is in fwb, it is the console recipe that is going to reference it, because that's where bin/console is. |
chalasr
approved these changes
Nov 13, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Nov 13, 2018
…BUG from argv via Application::bootstrapEnv() (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() This reverts commit 9253199, reversing changes made to 664a032. | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Replaced by symfony/recipes#491, see description there. Commits ------- f3c5fda Revert "bug #29154 [FrameworkBundle] Define APP_ENV/APP_DEBUG from argv via Application::bootstrapEnv() (chalasr)"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9253199, reversing
changes made to 664a032.
Replaced by symfony/recipes#491, see description there.