[PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refacto #31382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er refactoring (when using runInSeparateProcess)
7 tasks
greg0ire
approved these changes
May 4, 2019
|
@greg0ire It may occur on big refactos... Thank you for your feedback 🙂 |
|
Thank you @l-vo. |
nicolas-grekas
added a commit
that referenced
this pull request
May 5, 2019
…nErrorHandler refacto (l-vo) This PR was merged into the 4.3-dev branch. Discussion ---------- [PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refacto | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | During the refactoring for #29211 , it seems a little bug was introduced. When using runInSeparateProcess, deprecation message isn't unserialized anymore. Commits ------- f522729 [PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refactoring
l-vo
deleted the
fix_not_unserialized_logs_after_deprecation_handler_refacto
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the refactoring for #29211 , it seems a little bug was introduced. When using runInSeparateProcess, deprecation message isn't unserialized anymore.