[Lock] remove deprecated code #32555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
|
Has to be rebased when #32558 is merged and 4.4 is in master. |
stof
requested changes
Jul 16, 2019
|
Status: Needs Review |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Lock] remove usage of the StoreInterface | Q | A | ------------- | --- | Branch? |4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Followup PR according to the review of @nicolas-grekas in #32555 (comment). Commits ------- 9988844 [Lock] remove uusage of the StoreInterface
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 17, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Lock] remove usage of the StoreInterface | Q | A | ------------- | --- | Branch? |4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | none <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Followup PR according to the review of @nicolas-grekas in symfony/symfony#32555 (comment). Commits ------- 9988844eb4 [Lock] remove uusage of the StoreInterface
Simperfit
force-pushed
the
feature/lock-remove-store-interface
branch
from
a37c0dc
to
06e9a91
Compare
|
|
Simperfit
changed the title
Simperfit
force-pushed
the
feature/lock-remove-store-interface
branch
from
93d66c1
to
8ef13f3
Compare
Simperfit
force-pushed
the
feature/lock-remove-store-interface
branch
from
8ef13f3
to
48ab1da
Compare
|
PR Rebased. |
xabbuh
approved these changes
Jul 19, 2019
Tobion
reviewed
Jul 22, 2019
Tobion
reviewed
Jul 22, 2019
src/Symfony/Component/Lock/Tests/Store/ExpiringStoreTestTrait.php
Outdated
Show resolved
Hide resolved
Simperfit
force-pushed
the
feature/lock-remove-store-interface
branch
from
f63fffd
to
ebb0f1a
Compare
chalasr
approved these changes
Aug 5, 2019
chalasr
requested changes
Aug 5, 2019
Simperfit
force-pushed
the
feature/lock-remove-store-interface
branch
from
ebb0f1a
to
1c6ebc6
Compare
xabbuh
reviewed
Aug 6, 2019
Simperfit
force-pushed
the
feature/lock-remove-store-interface
branch
from
1c6ebc6
to
9b584fa
Compare
xabbuh
approved these changes
Aug 6, 2019
fabpot
approved these changes
Aug 6, 2019
fabpot
force-pushed
the
feature/lock-remove-store-interface
branch
from
9b584fa
to
008d135
Compare
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Aug 6, 2019
This PR was squashed before being merged into the 5.0-dev branch (closes #32555). Discussion ---------- [Lock] remove deprecated code | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | None <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> We are removing the StoreInterface And the Factory deprecated in 4.4. Commits ------- 008d135 [Lock] remove deprecated code
B-Galati
pushed a commit
to B-Galati/symfony
that referenced
this pull request
Aug 6, 2019
B-Galati
added a commit
to B-Galati/symfony
that referenced
this pull request
Aug 6, 2019
symfony-splitter
pushed a commit
to symfony/lock
that referenced
this pull request
Aug 6, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Aug 6, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Lock] remove un-needed implements interface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | null | License | MIT | Doc PR | not needed following #32555 it does not look necessary to implement both `PersistingStoreInterface` and `BlockingStoreInterface` Commits ------- b8459f7 [Lock] remove un-needed implements interface
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [Lock] remove deprecated waitAndSave() methods | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | missed in #32555 | License | MIT | Doc PR | Commits ------- fa18765 remove deprecated waitAndSave() methods
m-vo
pushed a commit
to m-vo/symfony
that referenced
this pull request
Sep 20, 2019
m-vo
pushed a commit
to m-vo/symfony
that referenced
this pull request
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are removing the StoreInterface And the Factory deprecated in 4.4.