[PropertyInfo] Deprecate PropertyInfo Type #53160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
mtarld
force-pushed
the
chore/deprecate-property-info-type
branch
5 times, most recently
from
6801f87
to
559105e
Compare
chalasr
requested changes
Dec 26, 2023
src/Symfony/Component/PropertyInfo/Extractor/ConstructorExtractor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/PropertyTypeExtractorInterface.php
Outdated
Show resolved
Hide resolved
mtarld
force-pushed
the
chore/deprecate-property-info-type
branch
2 times, most recently
from
12f79da
to
e6740da
Compare
mtarld
force-pushed
the
chore/deprecate-property-info-type
branch
from
e6740da
to
2ebbf09
Compare
mtarld
force-pushed
the
chore/deprecate-property-info-type
branch
5 times, most recently
from
db0f17e
to
7497a94
Compare
mtarld
force-pushed
the
chore/deprecate-property-info-type
branch
2 times, most recently
from
419469f
to
4f106ba
Compare
mtarld
force-pushed
the
chore/deprecate-property-info-type
branch
from
da8502d
to
6b68ad8
Compare
|
@mtarld as discussed at SymfonyLive, could you also try to update API Platform to use this patch? As we do extensive use of PropertyInfo (the component has initially be created as part of API Platform), this will validate that all use cases are covered and that we have a good migration path. Thanks! |
mtarld
force-pushed
the
chore/deprecate-property-info-type
branch
4 times, most recently
from
bf280d3
to
b4c7e67
Compare
|
@dunglas, I tried to use the type from TypeInfo component within API Platform, and so far I don't see any blocker. Indeed, the same BC/deprecation tricks in this PR can be done as well in API Platform. But, it is plenty of work, I'll try to send a draft PR soon. |
chalasr
approved these changes
Apr 3, 2024
chalasr
added
the
❄️ Feature Freeze
nicolas-grekas
approved these changes
Apr 3, 2024
src/Symfony/Component/PropertyInfo/Extractor/ConstructorExtractor.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Baptiste Leduc <baptiste.leduc@gmail.com>
mtarld
force-pushed
the
chore/deprecate-property-info-type
branch
from
b4c7e67
to
d32e81c
Compare
|
Thank you so much @mtarld, great work here |
This was referenced Apr 12, 2024
Merged
xabbuh
added a commit
that referenced
this pull request
May 15, 2024
…acts (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [PropertyInfo] remove no longer needed deprecation contracts | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT the dependency was introduced in #53160, but is no longer required since we reverted the deprecations in #54789 Commits ------- 18296cd remove no longer needed deprecation contracts
xabbuh
added a commit
that referenced
this pull request
May 17, 2024
…ue" on string" (michaljusiega, xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Serializer] Fixed "Warning: Attempt to read property "value" on string" | Q | A | ------------- | --- | Branch? | 7.1 (7.1.0-BETA1) | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fixed regresion of #53160 | License | MIT Hi! I've updated my project to `7.1.0-BETA1` and I found an error. After update I got: `Warning: Attempt to read property "value" on string` in `vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748` because in `733 line` the enum-case of value `TypeIdentifier` has been already readed.  Quite not sure if tests are possible here. Commits ------- 90251c9 add test 4b3dcf1 Fixed "Warning: Attempt to read property "value" on string"
symfony-splitter
pushed a commit
to symfony/serializer
that referenced
this pull request
May 17, 2024
…ue" on string" (michaljusiega, xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Serializer] Fixed "Warning: Attempt to read property "value" on string" | Q | A | ------------- | --- | Branch? | 7.1 (7.1.0-BETA1) | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fixed regresion of symfony/symfony#53160 | License | MIT Hi! I've updated my project to `7.1.0-BETA1` and I found an error. After update I got: `Warning: Attempt to read property "value" on string` in `vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748` because in `733 line` the enum-case of value `TypeIdentifier` has been already readed.  Quite not sure if tests are possible here. Commits ------- 90251c9361 add test 4b3dcf1ca6 Fixed "Warning: Attempt to read property "value" on string"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #52510.
As the TypeInfo's
Typeaims to represent types in the Symfony ecosystem, the PropertyInfo'sTypeneeds to be deprecated in favor of the first one.