-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PropertyInfo] Deprecate PropertyInfo Type #53160
Conversation
6801f87
to
559105e
Compare
src/Symfony/Component/PropertyInfo/Extractor/ConstructorExtractor.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/PropertyInfo/PropertyTypeExtractorInterface.php
Outdated
Show resolved
Hide resolved
12f79da
to
e6740da
Compare
e6740da
to
2ebbf09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
db0f17e
to
7497a94
Compare
419469f
to
4f106ba
Compare
da8502d
to
6b68ad8
Compare
@mtarld as discussed at SymfonyLive, could you also try to update API Platform to use this patch? As we do extensive use of PropertyInfo (the component has initially be created as part of API Platform), this will validate that all use cases are covered and that we have a good migration path. Thanks! |
bf280d3
to
b4c7e67
Compare
@dunglas, I tried to use the type from TypeInfo component within API Platform, and so far I don't see any blocker. Indeed, the same BC/deprecation tricks in this PR can be done as well in API Platform. But, it is plenty of work, I'll try to send a draft PR soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better.
I think this should make it in 7.1 so that we have at least one usage of the new type-info component internally, and we can iterate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see how this goes :)
src/Symfony/Component/PropertyInfo/Extractor/ConstructorExtractor.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Baptiste Leduc <baptiste.leduc@gmail.com>
b4c7e67
to
d32e81c
Compare
Thank you so much @mtarld, great work here |
…acts (xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [PropertyInfo] remove no longer needed deprecation contracts | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT the dependency was introduced in #53160, but is no longer required since we reverted the deprecations in #54789 Commits ------- 18296cd remove no longer needed deprecation contracts
…ue" on string" (michaljusiega, xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Serializer] Fixed "Warning: Attempt to read property "value" on string" | Q | A | ------------- | --- | Branch? | 7.1 (7.1.0-BETA1) | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fixed regresion of #53160 | License | MIT Hi! I've updated my project to `7.1.0-BETA1` and I found an error. After update I got: `Warning: Attempt to read property "value" on string` in `vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748` because in `733 line` the enum-case of value `TypeIdentifier` has been already readed. ![obraz](https://github.com/symfony/symfony/assets/16488888/5227ac76-0fb0-4b00-ab68-2394ab41d7b7) Quite not sure if tests are possible here. Commits ------- 90251c9 add test 4b3dcf1 Fixed "Warning: Attempt to read property "value" on string"
…ue" on string" (michaljusiega, xabbuh) This PR was merged into the 7.1 branch. Discussion ---------- [Serializer] Fixed "Warning: Attempt to read property "value" on string" | Q | A | ------------- | --- | Branch? | 7.1 (7.1.0-BETA1) | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fixed regresion of symfony/symfony#53160 | License | MIT Hi! I've updated my project to `7.1.0-BETA1` and I found an error. After update I got: `Warning: Attempt to read property "value" on string` in `vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748` because in `733 line` the enum-case of value `TypeIdentifier` has been already readed. ![obraz](https://github.com/symfony/symfony/assets/16488888/5227ac76-0fb0-4b00-ab68-2394ab41d7b7) Quite not sure if tests are possible here. Commits ------- 90251c9361 add test 4b3dcf1ca6 Fixed "Warning: Attempt to read property "value" on string"
This PR is a follow-up of #52510.
As the TypeInfo's
Type
aims to represent types in the Symfony ecosystem, the PropertyInfo'sType
needs to be deprecated in favor of the first one.