-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeInfo] mark classes as experimental #54788
Conversation
I should mark the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add "as experimental" to the changelog of the component also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog update needed
585579e
to
28b6495
Compare
Thank you @soyuka. |
I've added a note in CHANGELOG and README. |
…xperimental (soyuka) This PR was merged into the 7.1 branch. Discussion ---------- [PropertyInfo] remove deprecations, mark TypeInfo as experimental | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Follows #54788 as we can introduce these deprecation back when we feel the component is stable enough. Software like API Platform that heavily relies on the deprecated functionalities will have a really hard time migrating, we don't want to work more then needed and need to know we won't have to do the same work again in the next years. This also suggest that PropertyInfo can work with or without the new TypeInfo component while it's being experimental. Commits ------- 08ac161 [PropertyInfo] remove deprecations, mark TypeInfo as experimental
This is following a discussion on slack with authors of the component, I feel that the TypeInfo component should have an experimental phase as we need to prove the component's functionality on software that is built on top of type information extraction. Here's a non-exhaustive list of software using the PropertyInfo Type class (thanks to @mtarld):
These softwares should try their best in testing the new TypeInfo component and report back misfunctionalities and/or DX improvements before we can consider this non-experimental. See also #54789