[TypeInfo] mark classes as experimental #54788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should mark the new |
nicolas-grekas
approved these changes
Apr 30, 2024
dunglas
approved these changes
Apr 30, 2024
fabpot
approved these changes
May 2, 2024
fabpot
force-pushed
the
type-info-experimental
branch
from
585579e
to
28b6495
Compare
|
Thank you @soyuka. |
|
I've added a note in CHANGELOG and README. |
fabpot
added a commit
that referenced
this pull request
May 2, 2024
…xperimental (soyuka) This PR was merged into the 7.1 branch. Discussion ---------- [PropertyInfo] remove deprecations, mark TypeInfo as experimental | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Follows #54788 as we can introduce these deprecation back when we feel the component is stable enough. Software like API Platform that heavily relies on the deprecated functionalities will have a really hard time migrating, we don't want to work more then needed and need to know we won't have to do the same work again in the next years. This also suggest that PropertyInfo can work with or without the new TypeInfo component while it's being experimental. Commits ------- 08ac161 [PropertyInfo] remove deprecations, mark TypeInfo as experimental
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is following a discussion on slack with authors of the component, I feel that the TypeInfo component should have an experimental phase as we need to prove the component's functionality on software that is built on top of type information extraction. Here's a non-exhaustive list of software using the PropertyInfo Type class (thanks to @mtarld):
These softwares should try their best in testing the new TypeInfo component and report back misfunctionalities and/or DX improvements before we can consider this non-experimental. See also #54789