Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] removed deprecated methods from RouteCollection #7052

Closed
wants to merge 1 commit into from

Conversation

Tobion
Copy link
Member

@Tobion Tobion commented Feb 12, 2013

This PR removes the deprecated things from the RouteCollection for Symfony 2.3.

It's a WIP because it also contains test fixes which are going in 2.2 instead. This way, there are no deprecated calls in 2.2.

@fabpot
Copy link
Member

fabpot commented Mar 1, 2013

I've started a meta-PR to remove all deprecated stuff in 2.3. Can you split this PR into 2: one for 2.3 and another one for 2.2? Thanks.

@Tobion
Copy link
Member Author

Tobion commented Mar 1, 2013

@fabpot yes that was my plan

@Tobion
Copy link
Member Author

Tobion commented Mar 5, 2013

@fabpot I created #7266 for 2.2. When you merged that PR in 2.2 and then also master, I will rebase this PR.

@fabpot
Copy link
Member

fabpot commented Mar 6, 2013

#7266 has been merged and 2.2 has been merged into master.

@Tobion
Copy link
Member Author

Tobion commented Mar 6, 2013

@fabpot rebased.

@fabpot
Copy link
Member

fabpot commented Mar 6, 2013

Thanks, your commit is now part of #7227

@fabpot fabpot closed this Mar 6, 2013
@Tobion Tobion deleted the collection-2.3 branch March 6, 2013 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants