Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricting the test pack to 9.5 until symfony/phpunit-bridge supports 10 #19

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

weaverryan
Copy link
Member

Currently, following the docs:

composer require --dev symfony/test-pack
php bin/phpunit

Fails because this is no longer the correct way to initialize PHPUnit 10: https://github.com/symfony/recipes/blob/b1176e36c42b0738c1475960202d7e074863ca3c/symfony/phpunit-bridge/5.3/bin/phpunit#L11

We could (and should, I think) fix that line to also support PHPUnit 10. But restricting the pack to 9 seems even better, as installing phpunit/phpunit 10 and running vendor/bin/simple-phpunit currently fails, and will fail until symfony/phpunit-bridge supports PHPUnit 10.

@nicolas-grekas nicolas-grekas merged commit 7b708c5 into symfony:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants