[Turbo] Use blocks instead of partials to render turbo-streams #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
reviewed
Aug 9, 2023
weaverryan
reviewed
Aug 10, 2023
| + {{ block('task_form') }} | ||
| + </template> | ||
| +</turbo-stream> | ||
| <turbo-stream action="replace" targets="#my_div_id"> |
There was a problem hiding this comment.
Missing the closing block and this last turbo-stream looks extra to me
There was a problem hiding this comment.
well actually, this is a diff that applies to the snippet on L366, so yes, the endblock is missing and this line is here because this is just a subset of the full file
|
@nicolas-grekas is this ready for you ? Do you want me to handle last feedback you received ? |
|
@smnandre thanks for the reminder, feedback answered. |
kbond
approved these changes
Apr 18, 2024
|
Thank you Nicolas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on symfony/symfony#51327 for the call to
renderBlock().Using
targetswith a CSS selector empowers users with useful knowledge IMHO.