[LiveComponent] Store TemplateMap in build_dir
#1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per default `build_dir` = `cache_dir` so that won't change a thing. In projects having a distinct build directory, it fixes a bug where cache:clear did not create the file. (cf symfony#1522)
|
@althaus could you check if this change fixes your issue ? |
|
That patch fixes my described issues. |
kbond
approved these changes
Feb 21, 2024
carsonbot
added
Status: Reviewed
|
Thanks Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per default
build_dir=cache_dirso that won't change a thing for most of installs.But in projects with a distinct build directory, this PR fixes a bug where
cache:cleardid not create the file. (cf #1522)