Skip to content

[Twig] allow compound variant value to be string #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

[Twig] allow compound variant value to be string #1610

merged 1 commit into from
Mar 11, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Mar 11, 2024

Q A
Bug fix? yes
New feature? no
Issues n/a
License MIT

According to https://cva.style/docs/getting-started/variants#compound-variants, the compound variant values can be strings.

/cc @WebMamba

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 11, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 11, 2024
@kbond kbond merged commit 2562a6c into symfony:2.x Mar 11, 2024
@kbond kbond deleted the twig/string-compound-variants branch March 11, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebMamba WebMamba WebMamba approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbond @WebMamba @carsonbot