Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on only and without methods documentation #1633

Merged
merged 1 commit into from Mar 21, 2024

Conversation

JeanDavidDaviet
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Issues
License MIT

There are two typos in the only and without examples.
The intermediate representation still have the style and the classes attributes respectively.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 20, 2024
@kbond
Copy link
Member

kbond commented Mar 20, 2024

The reason these extra attributes were included was to explicitly show that they are excluded when rendering the component. Am I missing something - does it not work as expected?

@WebMamba
Copy link
Collaborator

Agree with @kbond here, I think the documentation show the right things here

@smnandre
Copy link
Collaborator

We may want to reverse the order to make it easier

1/ Calling template

2/ Component template

3/ HTML result

@kbond
Copy link
Member

kbond commented Mar 20, 2024

TBH, I don't have a good use-case for the only/without methods. If someone has a good use-case, let's update the docs to show.

@JeanDavidDaviet
Copy link
Contributor Author

thx @kbond for your input I understand more the reason.
I think @smnandre's idea is better as you can better see the initial values and compare it with the final result.
I've updated the PR.
I personnaly think it makes more sense this way, what do you think ?

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 21, 2024
@kbond
Copy link
Member

kbond commented Mar 21, 2024

Thank you Jean-David.

@kbond kbond merged commit 9d1fbf5 into symfony:2.x Mar 21, 2024
1 check passed
@JeanDavidDaviet JeanDavidDaviet deleted the patch-1 branch March 21, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants