Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Width / Height error when using an icon #1687

Closed
alexz707 opened this issue Apr 5, 2024 · 3 comments · Fixed by #1688
Closed

[Icons] Width / Height error when using an icon #1687

alexz707 opened this issue Apr 5, 2024 · 3 comments · Fixed by #1688
Labels
Bug Bug Fix Status: Needs Review Needs to be reviewed

Comments

@alexz707
Copy link

alexz707 commented Apr 5, 2024

Hi!
I've just installed the bundle and tried it out.
So far the 2 icons below are working fine.

<twig:UX:Icon name="flowbite:user-solid" class="w-6 h-6"/>
<twig:UX:Icon name="tabler:sun" class="w-6 h-6"/>

If I try to use a heroicon the following error appears:

<twig:UX:Icon name="heroicons:sun" class="w-6 h-6"/>

Error rendering "UX:Icon" component: The icon "heroicons:sun" does not have a width or height.

I've tried it with another icon (heroicons:sun-solid) and the same error appears.
Seems to me as there is something wrong with the heroicons?

Best regards
Alex
@smnandre
Copy link
Member

smnandre commented Apr 5, 2024

Thanks i'll look at it this week-end.

@smnandre smnandre mentioned this issue Apr 5, 2024
Merged
@smnandre
Copy link
Member

smnandre commented Apr 5, 2024

@alexz707 thanks for having reported this! This will be released in the next week or two

@javiereguiluz javiereguiluz added the Bug Bug Fix label Apr 9, 2024
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 9, 2024
javiereguiluz added a commit that referenced this issue Apr 9, 2024
@javiereguiluz
bug #1688 [Icons] Fix Icon missing width/height (smnandre)
4730718 
This PR was merged into the 2.x branch.

Discussion
----------

[Icons] Fix Icon missing width/height

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Issues        | Fix #1687
| License       | MIT

Extract width height from global response attributes.

Commits
-------

afd29a0 [Icons] Fix Icon missing width/height
@alexz707
Copy link
Author

Thanks for the fast fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug Fix Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Icons] Fix Icon missing width/height smnandre/ux
4 participants
@javiereguiluz @alexz707 @smnandre @carsonbot