[TwigComponent] Throws if exposed public prop is uninitialized #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cavasinf, does this sufficiently fix the two above issues for you? |
|
Ok to merge this PR while continuing the discussion about the remaining problems @cavasinf ? |
|
Yes 👍 |
|
(fabbot resolved in another PR) |
kbond
approved these changes
Apr 30, 2024
carsonbot
added
Status: Reviewed
|
Thanks Simon. |
|
This was a BC break.. |
kbond
added a commit
that referenced
this pull request
Jun 11, 2024
…property is unitialized (smnandre) This PR was merged into the 2.x branch. Discussion ---------- [TwigComponent][Fix] Revert throwing exception when public property is unitialized | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | Fix #1909 | License | MIT Revert #1780 If someone want to give another go at the original problem i'd appreciate. Commits ------- bf5959f [Fix] Revert throwing exception when public property is unitialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1686, fix
#1704