[LazyImage] Abstract image content fetching #1781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
Kocal
force-pushed
the
feat/GH-1773
branch
3 times, most recently
from
9b3c320 to
0a0d8fd
Compare
smnandre
reviewed
Apr 25, 2024
| @@ -74,8 +78,10 @@ private function doEncode(string $filename, int $encodingWidth = 75, int $encodi | |||
|
|
|||
| private function generatePixels(string $filename, int $encodingWidth, int $encodingHeight): array | |||
| { | |||
| $imageContent = ($this->fetchImageContent)($filename); | |||
There was a problem hiding this comment.
Maybe just a quick check on the result ?
smnandre
reviewed
Apr 25, 2024
smnandre
reviewed
Apr 25, 2024
smnandre
reviewed
Apr 25, 2024
smnandre
reviewed
Apr 25, 2024
kbond
requested changes
Apr 25, 2024
carsonbot
added
Status: Needs Work
- $this->fetchImageContent ??= fn (string $filename) => file_get_contents($filename);
+ $this->fetchImageContent ??= file_get_contents(...); |
carsonbot
added
Status: Needs Review
Kocal
commented
Apr 25, 2024
Comment on lines
+49
to
+53
| ->setArguments([ | ||
| new Reference('lazy_image.image_manager', ContainerInterface::NULL_ON_INVALID_REFERENCE), | ||
| null, // $cache | ||
| null, // $fetchImageContent | ||
| ]) |
There was a problem hiding this comment.
Looks like I can't set the 3rd argument if the 2nd argument has not been set, which can be the case if we have no cache configured, that's why I've changed to ->setArguments
|
Reviews have been applied, thanks :) |
smnandre
approved these changes
Apr 25, 2024
carsonbot
added
Status: Reviewed
kbond
approved these changes
Apr 26, 2024
|
Thank you Hugo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is a proposal for #1773, logic to fetch content image is now customizable thanks to closure, meaning that an end-user can use whatever solution he wants to fetch the image content (HttpClient, Flysystem, ...).
I'm not 100% about the
Closure::fromCallable(new Reference($config['fetch_image_content']))tho