[Fix] Revert removing twig_component.controllers_json
#1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed this key because it was an mistake (never used, documented, or written in recipes) I wrongly did not consider this a BC, and it was. So this PR re-adds the configuration key and deprecates it instead. Should this be acceptable in a hotfix version like 2.18.1 ?
stof
approved these changes
Jun 11, 2024
carsonbot
added
Status: Reviewed
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed this key because it was an mistake (never used, documented, or written in recipes)
I wrongly did not consider this a BC break, and it was.
This PR re-adds the configuration key and deprecates it instead.
--
Should this be acceptable in a hotfix version like 2.18.1 ?