[LiveComponent] Allow updates in arrays of DTOs #1990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrabenstein
changed the title
|
Thanks a lot for this PR @cgrabenstein! I was pretty sure most of the code was already one! Nice work! 🧡 |
WebMamba
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
I just tested, it work well! Thanks a lot @cgrabenstein to took the time to look at it! And to write good tests! See you soon! 🧡
carsonbot
added
Status: Reviewed
|
Thank you for checking it. What about the fabbot.io errors? I did not change the exception messages, so I'm not sure if I should apply the suggested patch. |
|
Great first contribution Christoph, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs allows changes in arrays of DTOs, see the linked issue for more background information.
There is one limitation though: For now it is not possible to generally set nested properties to be writable (i.e. something like
writable: 'items.*.prop', oritems[].prop). You either have to set everything to writable (writable: true), or a very specific element (writable: items.1.prop).