Skip to content

[Icon] Emphasis HTML syntax requires TwigComponent #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

[Icon] Emphasis HTML syntax requires TwigComponent #1994

merged 1 commit into from
Jul 18, 2024

Conversation

smnandre
Copy link
Member

First time HTML syntax is shown, use "tip" (green borders) instead of "note"

Fix: #1993

Before After
Capture d’écran 2024-07-17 à 21 17 54 - Grande Capture d’écran 2024-07-17 à 21 29 14

@smnandre
[Icon] Emphasis HTML syntax requires TwigComponent
f7838b7 
First time HTML syntax is shown, use "tip" (green borders) instead of "note" 

Fix: symfony#1993
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Jul 17, 2024
@smnandre smnandre added docs Improvements or additions to documentation Icons and removed Status: Needs Review Needs to be reviewed labels Jul 17, 2024
@smnandre smnandre requested a review from javiereguiluz July 17, 2024 20:28
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Jul 17, 2024
94noni
94noni approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@94noni 94noni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sens indeed

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jul 18, 2024
javiereguiluz
javiereguiluz approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is better. Thanks!

@javiereguiluz javiereguiluz merged commit fb040a4 into symfony:2.x Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

+1 more reviewer

@94noni 94noni 94noni approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs Improvements or additions to documentation Icons Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icons][Twig-Component] Update documentation for installation ux icons
4 participants
@smnandre @javiereguiluz @94noni @carsonbot