Skip to content

Update README.md #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

Update README.md #2038

merged 1 commit into from
Aug 8, 2024

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Aug 8, 2024

Q A
Bug fix? no

Hey, coming from the slack of @javiereguiluz of biomejs, seeing the recent map ux (which is 🔥 )
I've read the readme and I may propose some changes

  • 1 swap webpackencore and assetmapper (as per symfony doc)
  • 2 remove the autocomplete as its implemented
  • 3 the word "We" feels weird after 4+years of the release of this repo

feel free to challenge :)

thx

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 8, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 8, 2024
@javiereguiluz
Copy link
Member

Thanks Antoine.

@javiereguiluz javiereguiluz merged commit 6918605 into symfony:2.x Aug 8, 2024
37 of 38 checks passed
@94noni 94noni deleted the patch-1 branch August 9, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@94noni @javiereguiluz @Kocal @carsonbot