Skip to content

[TwigComponent] Optimize the ComponentLoggerListener #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

[TwigComponent] Optimize the ComponentLoggerListener #2167

merged 1 commit into from
Sep 16, 2024

Conversation

smnandre
Copy link
Member

  • Clean unused code
  • Reduce memory usage
  • Optimize class/templates lookup

kbond
kbond reviewed Sep 15, 2024
View reviewed changes
@smnandre smnandre added the DX label Sep 15, 2024
kbond
kbond approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 15, 2024
This was referenced Sep 15, 2024
Closed
Closed
@javiereguiluz
Copy link
Member

javiereguiluz commented Sep 16, 2024 •
edited
Loading

Nice! Maybe we can also remove the symfony/stopwatch dev dependency here?

ux/src/TwigComponent/composer.json

Line 43 in 8dd706d

"symfony/stopwatch": "^5.4|^6.0|^7.0",

@smnandre smnandre force-pushed the fix/streamline-logger-listener branch from af3a156 to 578f21e Compare September 16, 2024 18:51
@smnandre
[TwigComponent] Simplify the ComponentLoggerListener
19ff071 
* Clean unused code
* Reduce memory usage
* Optimize class/templates lookup
@smnandre smnandre force-pushed the fix/streamline-logger-listener branch from 578f21e to 19ff071 Compare September 16, 2024 18:52
@smnandre
Copy link
Member Author

Nice! Maybe we can also remove the symfony/stopwatch dev dependency here?

ux/src/TwigComponent/composer.json

Line 43 in 8dd706d

"symfony/stopwatch": "^5.4|^6.0|^7.0",

Absolutely, thank you for catching this!

@Kocal
Copy link
Member

Kocal commented Sep 16, 2024

Do... you think we can have some Blackfire profiles to show the performance improvments? 🙏🏻

@smnandre
Copy link
Member Author

Do... you think we can have some Blackfire profiles to show the performance improvments? 🙏🏻

I did not have time yet to configure it 😶‍🌫️

But i will in the next few days (already started a dedicated repo to measure performance of twig/live components)

@smnandre smnandre merged commit c1b7843 into symfony:2.x Sep 16, 2024
59 checks passed
@Kocal Kocal deleted the fix/streamline-logger-listener branch September 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
DX Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smnandre @javiereguiluz @Kocal @kbond @carsonbot