Skip to content

[LiveComponent] Fix variable in docs #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

[LiveComponent] Fix variable in docs #2402

merged 1 commit into from
Nov 22, 2024

Conversation

xDeSwa
Copy link
Contributor

@xDeSwa xDeSwa commented Nov 21, 2024

I think it's a wrong variable

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Nov 21, 2024
Kocal
Kocal approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes senses to me, thanks

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 21, 2024
@Kocal Kocal requested a review from smnandre November 21, 2024 10:06
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Nov 21, 2024
smnandre
smnandre reviewed Nov 22, 2024
View reviewed changes
@smnandre smnandre changed the title Fix variable in docs [LiveComponent] Fix variable in docs Nov 22, 2024
@smnandre smnandre added docs Improvements or additions to documentation LiveComponent labels Nov 22, 2024
@xDeSwa
Copy link
Contributor Author

xDeSwa commented Nov 22, 2024

yes, this better

smnandre
smnandre approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xDeSwa!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 22, 2024
@smnandre smnandre merged commit 23b3a25 into symfony:2.x Nov 22, 2024
2 checks passed
@smnandre smnandre mentioned this pull request Dec 23, 2024
Closed
@xDeSwa xDeSwa deleted the patch-3 branch July 18, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation LiveComponent Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xDeSwa @smnandre @Kocal @carsonbot