[LiveComponent] Fix default select value with preferred choices #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @1ed ! Thinking out loud here... I'm less and less enjoying this whole mecanism. I'm starting to wonder if we should not revert it.. instead of trying to decide PHP-side how the browsers behave 🤷♂️ |
smnandre
reviewed
Feb 22, 2025
smnandre
reviewed
Feb 22, 2025
src/LiveComponent/tests/Fixtures/Form/FormWithManyDifferentFieldsType.php
Show resolved
Hide resolved
smnandre
approved these changes
Feb 22, 2025
carsonbot
added
Status: Reviewed
1ed
force-pushed
the
fix-preferred-choices-default-value
branch
from
080d402 to
6dc6a33
Compare
Probably would be better yes, but I don't know the internals, why was this necessary originally, just wanted to fix the bug. |
|
Of course, and thank you again for that ! It was really thinking outloud :)) |
Kocal
approved these changes
Feb 23, 2025
Kocal
changed the title
|
Thank you @1ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are preferred_choices set for a choice type Symfony
renders them before the actual choices so the default value in the
browser will be the first value of the preferred choices.