Skip to content

[ToolKit] Add missing Interface suffixes #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

[ToolKit] Add missing Interface suffixes #2717

merged 1 commit into from
May 7, 2025

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented May 6, 2025

Fix #2539

@smnandre smnandre requested a review from Kocal May 6, 2025 20:05
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label May 6, 2025
nicolas-grekas
nicolas-grekas approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 6, 2025
@Kocal
Copy link
Member

Kocal commented May 7, 2025

I can't verify since I'm on my phone, but do we use any of these interfaces in the Website too?

@Kocal
Copy link
Member

Kocal commented May 7, 2025

Thank you @smnandre.

@Kocal Kocal merged commit 7f934c4 into symfony:2.x May 7, 2025
80 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer Toolkit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smnandre @Kocal @nicolas-grekas @carsonbot