Skip to content

[Site] Trim Icon's DataList's <dd> to get a better copy value #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

CyrilKrylatov
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Docs? no
Issues Fix #2831
License MIT

On Icon's modal, there is a space at the end of DD's HTML element:

image

So when double-click on it and copy it, we'll copy this space as well.

This PR fixes that space.

Before:

image

After:

image

@carsonbot carsonbot added Bug Bug Fix Icons Status: Needs Review Needs to be reviewed labels Jun 12, 2025
@Kocal Kocal changed the title [Icons] Trim DataList's dd to get a better copy value [Site] Trim Icon's DataList's dd to get a better copy value Jun 13, 2025
@Kocal Kocal changed the title [Site] Trim Icon's DataList's dd to get a better copy value [Site] Trim Icon's DataList's <dd> to get a better copy value Jun 13, 2025
@Kocal Kocal added Site ux.symfony.com and removed Icons labels Jun 13, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jun 13, 2025
@Kocal
Copy link
Member

Kocal commented Jun 13, 2025

Thank you @CyrilKrylatov.

@Kocal Kocal merged commit 7292e1a into symfony:2.x Jun 13, 2025
4 checks passed
@CyrilKrylatov CyrilKrylatov deleted the datalist_trim_space branch June 13, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Site ux.symfony.com Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icons] Trim Metadata's field to get a better copy value
3 participants