[Icons] Document icon_sets configuration
#2938
Merged
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
commented
Jul 24, 2025
Comment on lines
+631
to
+634
| # Icon sets configuration, array of prefix => icon set configuration | ||
| icon_sets: | ||
| # Icon set for "flags", can be used like this: ux_icon('flags:fr') | ||
| flags: |
There was a problem hiding this comment.
I didn't add any "added in 2.20", this version is pretty old right now
carsonbot
added
Status: Reviewed
smnandre
reviewed
Jul 25, 2025
| flags: | ||
| It can either be mapped to a local directory... | ||
| path: '%kernel.project_dir%/assets/images/flags' | ||
| ... or to an existing icon set identifier |
There was a problem hiding this comment.
Suggested change
| ... or to an existing icon set identifier | |
| # ... or to an existing icon set identifier |
smnandre
reviewed
Jul 25, 2025
| icon_sets: | ||
| # Icon set for "flags", can be used like this: ux_icon('flags:fr') | ||
| flags: | ||
| It can either be mapped to a local directory... |
There was a problem hiding this comment.
Suggested change
| It can either be mapped to a local directory... | |
| # It can either be mapped to a local directory... |
Kocal
added a commit
to Kocal/symfony-ux
that referenced
this pull request
Jul 25, 2025
Kocal
added a commit
that referenced
this pull request
Jul 25, 2025
#2938 (Kocal) This PR was merged into the 2.x branch. Discussion ---------- [Icons] Fix `icon_sets` configuration documentation, follow #2938 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | yes <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Following #2938 Commits ------- f5884b3 [Icons] Fix `icon_sets` configuration documentation, follow #2938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2156