Skip to content

Conversation

kbond
Copy link
Member

@kbond kbond commented Mar 14, 2022

Q A
Bug fix? yes
New feature? no
Tickets n/a
License MIT

Fixes a regression in 2.1 where a nullable entity is attempted to be loaded from Doctrine. In 2.0, null was dropped from the component data loading the entity wasn't attempted.

@kbond
Copy link
Member Author

kbond commented Mar 14, 2022

I wonder if this change should be in the hydration system itself:

  1. If raw prop === the property's default, skip
  2. If raw prop === null and the property allows null, skip

@kbond kbond force-pushed the nullable-entity branch from ccebbfc to 03188d8 Compare March 14, 2022 13:15
@weaverryan
Copy link
Member

I wonder if this change should be in the hydration system itself:

Let's keep the behavior simple and predictable (i.e. always run a value through the hydration system) :)

@weaverryan
Copy link
Member

Thank you Kevin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants