Skip to content

Apply fabbot rules #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

Apply fabbot rules #2957

merged 1 commit into from
Jul 29, 2025

Conversation

nicolas-grekas
Copy link
Member

Q A
Bug fix? no
New feature? no
Docs? no
Issues -
License MIT
  • no-void to test cases
  • typos
  • tweaks to exception messages

@nicolas-grekas nicolas-grekas requested a review from Kocal as a code owner July 29, 2025 14:53
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Jul 29, 2025
@nicolas-grekas
Copy link
Member Author

(fabbot's failures are false-positive typos.)

@Kocal
Copy link
Member

Kocal commented Jul 29, 2025 •
edited
Loading

For Turbo, we will need to configure PHPStan to ignore missingType.return errors on tests/**/*.php files

Kocal
Kocal reviewed Jul 29, 2025
View reviewed changes
@nicolas-grekas nicolas-grekas force-pushed the cs branch 2 times, most recently from 03365f4 to a08a810 Compare July 29, 2025 15:18
@nicolas-grekas
Copy link
Member Author

We will need to configure PHPStan to ignore missingType.return errors on tests/**/*.php files

done!

Kocal
Kocal approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Don't worry about PHP 8.4 & Windows failing checks, there are known issues and unrelated to your PR

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jul 29, 2025
@Kocal
Copy link
Member

Kocal commented Jul 29, 2025

Pretty happy with codespell's corrections

@Kocal
Copy link
Member

Kocal commented Jul 29, 2025

Thank you @nicolas-grekas.

@Kocal Kocal merged commit 1f90d60 into symfony:2.x Jul 29, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @Kocal @carsonbot