fix(live): fix testing events #1113
Conversation
| throw new \InvalidArgumentException(sprintf('Event "%s" does not exist on component "%s".', $event, $this->metadata->getName())); | ||
| } | ||
|
|
||
| return $this->request(['actions' => $actions], '_batch'); |
There was a problem hiding this comment.
Super minor, and it shouldn't make any difference, but if we have just one action, it won't process through batch: it'll just call that one action directly.
There was a problem hiding this comment.
The js makes this distinction?
There was a problem hiding this comment.
Exactly. The js always tries to use the normal endpoint (either for calling a LiveAction or the "default" action in the case of a re-render). If it finds that it has 2 things queued at once, then it goes through batch. https://github.com/symfony/ux/blob/2.x/src/LiveComponent/assets/src/Backend/RequestBuilder.ts#L71-L79
There was a problem hiding this comment.
Ok, I'll match in the helper.
There was a problem hiding this comment.
This change has been made.
kbond
force-pushed
the
live-test-emit
branch
from
bf02e80
to
3bb139b
Compare
|
Thanks Kevin! |
When implementing #823, I made the wrong assumption that events were identical to actions. This fixes that.