Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Accept <twig:ux:icon /> (lowercase) #1659

Merged
merged 1 commit into from
Mar 25, 2024
Merged

[Icons] Accept <twig:ux:icon /> (lowercase) #1659

merged 1 commit into from
Mar 25, 2024

Conversation

smnandre
Copy link
Member

Q A
Bug fix? no
New feature? no
Issues Fix #1657
License MIT

Fix #1657

Allow

<twig:UX:Icon ... />

and

<twig:ux:icon ... />

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 25, 2024
kbond
kbond requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to prove? (renaming one of the existing calls to lowercase is enough)

@carsonbot carsonbot added Status: Needs Work Additional work is needed Status: Needs Review Needs to be reviewed and removed Status: Needs Review Needs to be reviewed Status: Needs Work Additional work is needed labels Mar 25, 2024
@smnandre
Copy link
Member Author

Can you add a test to prove? (renaming one of the existing calls to lowercase is enough)

Good!

@smnandre smnandre requested a review from kbond March 25, 2024 20:49
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Mar 25, 2024
@kbond kbond force-pushed the feat/allow-ux-icon-lowercase branch from b1b3641 to 9c037b4 Compare March 25, 2024 20:51
@kbond
Copy link
Member

kbond commented Mar 25, 2024

Thanks Simon.

@kbond kbond merged commit 9e44360 into symfony:2.x Mar 25, 2024
5 checks passed
@smnandre smnandre mentioned this pull request Sep 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icons] <twig:UX:icon .../> casing issue
3 participants
@smnandre @kbond @carsonbot