Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp(biomejs): upgrade Biomejs, fix patterns, don't use yarn workspaces #2015

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jul 30, 2024

Q A
Bug fix? yes/no
New feature? yes/no
Issues Fix #...
License MIT

Following #1848:

  • It looks like glob pattern like src/*/{src,test} (the {a,b} part) were not working
  • I've configured files to lint/format in our biome.json.
  • I've also upgraded Biomejs to ^1.8.3
  • I've rerun Biome lint/format on the whole codebase

Sorry for the big PR 🙏🏻

@carsonbot carsonbot added Bug Bug Fix Feature New Feature Status: Needs Review Needs to be reviewed labels Jul 30, 2024
@Kocal Kocal added DX and removed Bug Bug Fix Feature New Feature labels Jul 30, 2024
@Kocal Kocal requested a review from javiereguiluz July 30, 2024 17:46
@Kocal Kocal force-pushed the imp/biomejs-lint branch 2 times, most recently from dffd1bc to df55f5f Compare July 30, 2024 17:55
@Kocal Kocal changed the title imp(pkg): don't use yarn workspaces for lint/check-lint imp(biomejs): upgrade Biomejs, fix patterns, don't use yarn workspaces Jul 30, 2024
@Kocal Kocal force-pushed the imp/biomejs-lint branch 2 times, most recently from 89e8664 to 5f2b0ce Compare July 30, 2024 18:15
@smnandre
Copy link
Member

Any effect on CI test Times ?

@Kocal
Copy link
Member Author

Kocal commented Jul 30, 2024

Oops, before/after were present before editing the PR description, but yes!

For linting check:

And for formatting check, well it was broken... 😅:

@javiereguiluz
Copy link
Member

Thanks for this fix/improvement! In addition to being very good at fixing issues, I love how fast Biome.js is 😍

@javiereguiluz javiereguiluz merged commit e1d2f19 into symfony:2.x Jul 30, 2024
3 of 4 checks passed
@Kocal Kocal deleted the imp/biomejs-lint branch July 30, 2024 20:00
@smnandre
Copy link
Member

@Kocal terrific!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants