[TwigComponent] Remove $tag parameter from *Node, as it is now deprecated by twig/twig 3.12#2114
Merged
kbond merged 1 commit intosymfony:2.xfrom Aug 31, 2024
Merged
Conversation
…precated by twig/twig 3.12
Member
|
Thanks Hugo. |
Member
|
I think we will release a 2.20 in a week or two.. Do we need to release a version directly when Twig releases one ? In the meantime can you use the 2.x-dev ? |
|
Yeah right, it's just a choice in our CI pipeline to fail with deprecations and I could update to the dev version in the meantime. Sorry for the stir up :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the deprecations added in twig/twig 3.12, about the
$tagparameter fromNodeclass: