Allow to add extra plugin #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
approved these changes
Jun 15, 2017
|
Thank you Alain! |
weaverryan
added a commit
that referenced
this pull request
Jun 20, 2017
This PR was squashed before being merged into the master branch (closes #19). Discussion ---------- Allow to add extra plugin Encore does not support adding an extra plugin to the list of registered plugins. In Symfony demo, we try to reduce the size of one of our entries and have to manually add the plugin to the config by doing this : ```js var config = Encore.getWebpackConfig(); config.plugins.push(new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/)); ``` I propose to update the API of Encore through a new method `addPlugin(plugin)`. ```js Encore // ... .addPlugin(new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/)) ``` Commits ------- dbe7ea2 Merge branch 'master' into add-plugins 225a0da Allow to add extra plugin
|
Docs issue: symfony/symfony-docs#8070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encore does not support adding an extra plugin to the list of registered plugins.
In Symfony demo, we try to reduce the size of one of our entries and have to manually add the plugin to the config by doing this :
I propose to update the API of Encore through a new method
addPlugin(plugin).