Skip to content

Update factory-families.md - Round #2 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

kbond
Copy link

@kbond kbond commented Sep 5, 2024

No description provided.

@kbond kbond requested a review from MolloKhan September 5, 2024 22:25
Copy link
Contributor

@MolloKhan MolloKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both suggestions. Thanks Kevin

@kbond kbond merged commit dc961e8 into ep2-factory-families Sep 6, 2024
@kbond kbond deleted the kbond-patch-1 branch September 6, 2024 01:11
kbond added a commit that referenced this pull request Sep 6, 2024
* add factory-families.md script

* Update factory-families.md - Round #1 (#40)

* Update factory-families.md - Round #1

This needs the usual double checking. There's some stuff in line 25 that I left because I wasn't 100% sure about it (the link and the [ ]).

Diego: The misspelling of "Konami" is likely fixable if you can give me a screenshot of your screen with that line spelled correctly. I can cut the line out and add it over the video file.

* some tweaks to the script file

* more tweaks

---------

Co-authored-by: Diego Aguiar <barret91@hotmail.com>

* Update factory-families.md (#41)

* fix optional value for input

---------

Co-authored-by: Danielle <berealady9@gmail.com>
Co-authored-by: Kevin Bond <kevinbond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants