Skip to content

Add missing target-language attr to all translations #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

Add missing target-language attr to all translations #230

merged 1 commit into from
Jul 5, 2022

Conversation

bocharsky-bw
Copy link
Member

@jrushlow jrushlow added Feature New Feature Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer and removed Feature New Feature labels Jul 5, 2022
jrushlow
jrushlow approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bocharsky-bw

@jrushlow
Copy link
Contributor

jrushlow commented Jul 5, 2022

test failures unrelated

@jrushlow jrushlow merged commit ec97dee into SymfonyCasts:main Jul 5, 2022
@bocharsky-bw bocharsky-bw deleted the target-lang branch July 6, 2022 08:22
@jrushlow jrushlow mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jrushlow jrushlow jrushlow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bocharsky-bw @jrushlow