Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the base branch of the PR when getting the version #59

Merged
merged 7 commits into from
Mar 24, 2019
Merged

Conversation

asmeurer
Copy link
Member

I need to test that this is correct before updating the tests.

Fixes #58.

I need to test that this is correct before updating the tests.

Fixes #58.
@asmeurer asmeurer temporarily deployed to sympy-bot-testing March 24, 2019 22:41 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing March 24, 2019 22:51 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing March 24, 2019 22:52 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing March 24, 2019 22:59 Inactive
@asmeurer asmeurer temporarily deployed to sympy-bot-testing March 24, 2019 23:10 Inactive
@asmeurer
Copy link
Member Author

Demo: asmeurer/GitHub-Issues-Test#43

@asmeurer
Copy link
Member Author

You can see at the demo when I changed the base branch between master (which has the version 1.2.1.dev in the release file) and 1.4 (which has the version 1.4rc1 in the release file), it uses the correct version in the URL.

@asmeurer asmeurer merged commit 9189f57 into master Mar 24, 2019
@asmeurer asmeurer deleted the base-branch branch March 24, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant