Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add physics.control as a valid submodule #87

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

namannimmo10
Copy link
Member

No description provided.

@asmeurer
Copy link
Member

Can you reference the PR this is being added in?

@asmeurer
Copy link
Member

#88 should fix the test failures.

@namannimmo10
Copy link
Member Author

Can you reference the PR this is being added in?

sympy/sympy#19390
For now, I have added NO ENTRY in the release notes.

@asmeurer
Copy link
Member

asmeurer commented Jun 1, 2020

Is it still open whether or not this will be the name of the module, or is it decided? If it is decided, we can merge this so that you can add an entry when that PR is merged.

@namannimmo10
Copy link
Member Author

Yes, it is decided that the name of the module would be physics.control. There's also a label named after it there.

@asmeurer asmeurer merged commit 0a3d9a5 into sympy:master Jun 1, 2020
@namannimmo10 namannimmo10 deleted the physics.control branch June 1, 2020 19:16
@asmeurer
Copy link
Member

asmeurer commented Jun 1, 2020

OK, this has been deployed. You can add a release notes entry for the control package now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants